Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ChainType choices (to support consumer chains) #213

Merged
merged 4 commits into from
Dec 11, 2024
Merged

fix: ChainType choices (to support consumer chains) #213

merged 4 commits into from
Dec 11, 2024

Conversation

bap2pecs
Copy link
Collaborator

@bap2pecs bap2pecs commented Dec 11, 2024 •
edited
Loading

Summary

fix a small bug which was introduced in #155

this caused FP failed to start

bash-5.1$ fpd start
service injective.evm.v1beta1.Msg does not have cosmos.msg.v1.service proto annotation
Error: failed to load configuration: /home/finality-provider/.fpd/fpd.conf:6: Invalid value `OPStackL2' for option `--chaintype'. Allowed values are: 
Usage:
  fpd start [flags]

Test Plan

tested with a new docker image created by CI

babylonlabs/finality-provider:9fcbde4fdacd26de256a944dedacb645826c2e9e

and it doesn't have this error anymore

@bap2pecs
Copy link
Collaborator Author

image

this one still seems flaky. rerunning.

@bap2pecs bap2pecs merged commit 8e8384a into base/consumer-chain-support Dec 11, 2024
15 checks passed
@bap2pecs bap2pecs deleted the fix/chaintype branch December 11, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SebastianElvis SebastianElvis SebastianElvis approved these changes

@gitferry gitferry Awaiting requested review from gitferry

@lesterli lesterli Awaiting requested review from lesterli

@parketh parketh Awaiting requested review from parketh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bap2pecs @SebastianElvis